HealthContributor beans managed by a CompositeHealthContributor are recreated on each call #31676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@philwebb could you take a look at this one please? You mentioned on the issue that we'd need to be careful about backwards compatibility. |
philwebb
pushed a commit
that referenced
this pull request
Jul 26, 2022
Update `NamedContributorsMapAdapter` so that the adapter function is called only once per entry. Prior to this commit, the adapter was called dynamically which made `CompositeHealthContributor` behave differently from a regular `HealthContributor`. See gh-31676
philwebb
added a commit
that referenced
this pull request
Jul 26, 2022
philwebb
added
type: bug
Member
|
I think my original concern was that existing users might be relying on the dynamic adapter code. I've pushed the PR with a polish commit, but I think I'll change it a little more so that the adaption is done on first access rather than during construction. |
Member
|
Actually, on second thoughts, I think things are fine. We previously called the Thanks for the PR @terminux |
philwebb
added a commit
that referenced
this pull request
Jul 27, 2022
Update `NamedContributorsMapAdapter` to collect items to a `LinkedHashMap` rather than a `HashMap`. See gh-31676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the construction of the
NamedContributorsMapAdapter, each value adapter is called only once.Closes gh-29640