Add support for customizing WebJars resource handler path pattern #31769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, both Spring MVC and Spring WebFlux auto-configurations hardcode path pattern for WebJars resource handlers to "/webjars/**" which means users are unable to change the path. This commit introduces "spring.mvc.webjars-path-pattern" and "spring.webflux.webjars-path-pattern" configuration properties that allow customization of WebJars resource handler path pattern.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
philwebb
removed
the
for: team-meeting
snicoll
pushed a commit
that referenced
this pull request
Sep 7, 2022
At present, both Spring MVC and Spring WebFlux auto-configurations hardcode the path pattern for WebJars resource handlers to "/webjars/**", which means users are unable to change the path. This commit introduces "spring.mvc.webjars-path-pattern" and "spring.webflux.webjars-path-pattern" configuration properties that allow customization of WebJars resource handler path pattern. See gh-31769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, both Spring MVC and Spring WebFlux auto-configurations hardcode path pattern for WebJars resource handlers to
/webjars/**which means users are unable to change the path.This commit introduces
spring.mvc.webjars-path-patternandspring.webflux.webjars-path-patternconfiguration properties that allow customization of WebJars resource handler path pattern.The background of the proposal is that using
/webjars/**in path is somewhat leaky as it tells details about the tech stack. For that reason I usually prefer mapping WebJars to a more generic path, like/assets/**. Ideally, the default should also be a generic one but I'm not sure if that's a welcome change so it's probably one of the topics for team to discuss.