Add socketKeepAlive configuration property for Elasticsearch

[puppylpg]

Keepalive property for the connection between client and elasticsearch should be considered as configurable. Futher more, i do think it's good to keep it alive by default.

Here is the issue:

When read/write elasticsearch in high concurrency, threads have chances to stuck on obsolete connection between client and elasticsearch. The more threads involves, the quicker stucking on connection happens. The reason is described here:

Worse, if the connection is dropped silently while a request is in flight then the client may block indefinitely since it will send no more data on this connection and will therefore never find out that it's been closed.

And here is the situation i run into. Logs can also be found here:

• https://stackoverflow.com/questions/73217318/elasticsearch-java-response-stuck

similar issue:

• RestClient performRequest thread wait no timeout， thread brock elastic/elasticsearch#65909

However, spring boot can't config keepalive through current properties. We have to write some config codes like:

    @Bean
    public RestClientBuilderCustomizer keepalive() {
        return new RestClientBuilderCustomizer() {
            @Override
            public void customize(RestClientBuilder builder) {

            }

            @Override
            public void customize(HttpAsyncClientBuilder builder) {
                builder.setDefaultIOReactorConfig(IOReactorConfig.custom().setSoKeepAlive(true).build());
                log.info("es tcp keep-alive must be enabled!");
            }
        };
    }

So i add some support for spring.elasticsearch.keepalive=true to make it easier to config.

[pivotal-cla]

@puppylpg Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@puppylpg Thank you for signing the Contributor License Agreement!

[wilkinsona]

Thanks for the proposal, @puppylpg. I've left a couple of comments for you consideration. In addition to those, it would be good to have a test that verifies that our default for the new property aligns with Elasticsearch's default. If the Elastic default is changed in the future, this will ensure that we notice and can update our default to match.

[puppylpg]

resolved

[wilkinsona]

Thanks for the updates. I've left a comment about the testing of Elastic's default.

[snicoll]

@puppylpg thank you for making your first contribution to Spring Boot.

[puppylpg]

Will this mr be merged into 2.x.x besides 3.0.0-M5?

[wilkinsona]

Sorry, it won't. It's an enhancement so it only belongs in a new major or minor release. We don't have any plans at the moment for a 2.8 release so 3.0 is the next available release in which it can be included.

[puppylpg]

ok, thanks for your reply (sad, for still using jdk8 in our production environment 😅😅😅)