Allow multiple hosts to be set in MongoProperties #32125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently MongoProperties allow only single host to be set in the MongoProperties. With this commit a set of 'additional hosts' can be set along with the base host/port. This closes spring-projects#32113
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
requested changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks @thegeekyasian, I've added a few review comments for you to consider.
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/mongo/MongoProperties.java
Outdated
Show resolved
Hide resolved
...springframework/boot/autoconfigure/mongo/MongoPropertiesClientSettingsBuilderCustomizer.java
Show resolved
Hide resolved
...boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Outdated
Show resolved
Hide resolved
Thanks for the feedback @philwebb, agreed upon the points mentioned and the suggested changes have been done. Ready for a review |
philwebb
added
type: enhancement
philwebb
pushed a commit
that referenced
this pull request
Aug 24, 2022
Update `MongoProperties` with an `additional-hosts` property which can be used to configure MongoDB in a multi-host environment. See gh-32125
philwebb
added a commit
that referenced
this pull request
Aug 24, 2022
|
Thanks for the updates @thegeekyasian. This has now been merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MongoProperties allow only single host to be set in the MongoProperties.
With this commit a set of 'additional hosts' can be set along with the base host/port.
This closes #32113