Skip to content

Allow multiple hosts to be set in MongoProperties #32125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thegeekyasian
Copy link
Contributor

Currently MongoProperties allow only single host to be set in the MongoProperties.
With this commit a set of 'additional hosts' can be set along with the base host/port.

This closes #32113

Currently MongoProperties allow only single host to be set in the MongoProperties. 
With this commit a set of 'additional hosts' can be set along with the base host/port.

This closes spring-projects#32113
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 21, 2022
@thegeekyasian
Copy link
Contributor Author

Hi @snicoll / @philwebb, can you please review this PR to support additional hosts, based on the discussion here.

Copy link
Member

@philwebb philwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thegeekyasian, I've added a few review comments for you to consider.

@philwebb philwebb marked this pull request as draft August 22, 2022 16:52
@thegeekyasian thegeekyasian marked this pull request as ready for review August 22, 2022 18:03
@thegeekyasian thegeekyasian requested a review from philwebb August 22, 2022 18:06
@thegeekyasian
Copy link
Contributor Author

Thanks @thegeekyasian, I've added a few review comments for you to consider.

Thanks for the feedback @philwebb, agreed upon the points mentioned and the suggested changes have been done.

Ready for a review

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 24, 2022
@philwebb philwebb added this to the 3.0.x milestone Aug 24, 2022
@philwebb philwebb self-assigned this Aug 24, 2022
philwebb pushed a commit that referenced this pull request Aug 24, 2022
Update `MongoProperties` with an `additional-hosts` property which
can be used to configure MongoDB in a multi-host environment.

See gh-32125
@philwebb philwebb closed this in 5fcc394 Aug 24, 2022
@philwebb philwebb modified the milestones: 3.0.x, 3.0.0-M5 Aug 24, 2022
@philwebb
Copy link
Member

Thanks for the updates @thegeekyasian. This has now been merged to main and will be part of the 3.0 release.

@thegeekyasian thegeekyasian deleted the geekyasian-32113 branch August 24, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple hosts to be set in MongoProperties
3 participants