Skip to content

Eagerly initialize SimplePropertyValueConversions #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Eagerly initialize SimplePropertyValueConversions #2591

wants to merge 4 commits into from

Conversation

christophstrobl
Copy link
Member

Resolves: #2590

@christophstrobl christophstrobl requested a review from mp911de April 4, 2022 08:18
@christophstrobl
Revert "Synchronize initialization of SimplePropertyValueConversions."
6ee9976 
This reverts commit 477c69f.
@christophstrobl
Rely on contract of InitializingBean.
3bafd10 
Remove all ad-hoc initialization in favor of InitializingBean contract.
@christophstrobl christophstrobl mentioned this pull request Apr 4, 2022
Closed
@mp911de mp911de changed the title Synchronize initialization of SimplePropertyValueConversions. Eagerly initialize SimplePropertyValueConversions Apr 5, 2022
mp911de pushed a commit that referenced this pull request Apr 5, 2022
@christophstrobl @mp911de
Eagerly initialize SimplePropertyValueConversions.
fe124ca 
Closes #2590
Original pull request: #2591.
mp911de added a commit that referenced this pull request Apr 5, 2022
@mp911de
Polishing.
55c0ca8 
Improve null-safety. Refine exception signature to avoid exception catching.

See #2590
Original pull request: #2591.
mp911de pushed a commit that referenced this pull request Apr 5, 2022
@christophstrobl @mp911de
Eagerly initialize SimplePropertyValueConversions.
b9eb4d1 
Closes #2590
Original pull request: #2591.
mp911de added a commit that referenced this pull request Apr 5, 2022
@mp911de
Polishing.
0792b74 
Improve null-safety. Refine exception signature to avoid exception catching.

See #2590
Original pull request: #2591.
@mp911de mp911de added the type: bug A general bug label Apr 5, 2022
@mp911de mp911de added this to the 2.7 RC1 (2021.2.0) milestone Apr 5, 2022
@mp911de mp911de marked this pull request as ready for review April 5, 2022 07:30
@mp911de
Copy link
Member

mp911de commented Apr 5, 2022

That's merged and backported now.

@mp911de mp911de closed this Apr 5, 2022
@mp911de mp911de deleted the issue/2590 branch April 5, 2022 07:30
@mp911de mp911de mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.7 RC1 (2021.2.0)
Development

Successfully merging this pull request may close these issues.

Synchronize initialization of SimplePropertyValueConversions.
2 participants
@christophstrobl @mp911de