Proposal to fix #2531 adding explode modifier * to sort attribute
#2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2023 11:32
…'sort' parameter template variable
…'sort' parameter template variable Adding author in header
|
@motofix Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@motofix Thank you for signing the Contributor License Agreement! |
odrotbohm
requested changes
Oct 2, 2023
src/main/java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolver.java
Outdated
Show resolved
Hide resolved
…'sort' parameter template variable Using TemplateVariable.composite
|
LGTM, I'll take it from here. Likely by the end of the week. Thanks for contributing this, Julien! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi, any news on this ? |
|
Sorry for the delay and thanks for bumping this. I'll have a loot ASAP, this time for sure, I promise. |
|
This is polished and back-ported to the 3.1.x maintenance branch. Thanks again for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding explode modifier
*tosortattribute, making client libraries like Ketting to behave correctly and generate request compliant with SpringProposal to fix #2531