Fix docs on creation of EntityManagerFactory #180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously EntityManagerFactory was created manually which resulted in `LocalContainerEntityManagerFactoryBean` not being exposed to ApplicationContext. The latter is an important bean since it enables exception translation. The fact that factory bean implements additional mechanisms is probably a mistake in the design. But I guess we have to live with this now.
odrotbohm
pushed a commit
that referenced
this pull request
Nov 3, 2016
…ocumentation. Previously EntityManagerFactory was created manually which resulted in LocalContainerEntityManagerFactoryBean not being exposed to ApplicationContext. The latter is an important bean since it enables exception translation. Original pull request: #180.
odrotbohm
pushed a commit
that referenced
this pull request
Nov 3, 2016
…ocumentation. Previously EntityManagerFactory was created manually which resulted in LocalContainerEntityManagerFactoryBean not being exposed to ApplicationContext. The latter is an important bean since it enables exception translation. Original pull request: #180.
odrotbohm
pushed a commit
that referenced
this pull request
Nov 3, 2016
…ocumentation. Previously EntityManagerFactory was created manually which resulted in LocalContainerEntityManagerFactoryBean not being exposed to ApplicationContext. The latter is an important bean since it enables exception translation. Original pull request: #180.
|
That's merged. |
odrotbohm
pushed a commit
that referenced
this pull request
Nov 3, 2016
…ocumentation. Previously EntityManagerFactory was created manually which resulted in LocalContainerEntityManagerFactoryBean not being exposed to ApplicationContext. The latter is an important bean since it enables exception translation. Original pull request: #180.
odrotbohm
pushed a commit
that referenced
this pull request
Nov 3, 2016
…ocumentation. Previously EntityManagerFactory was created manually which resulted in LocalContainerEntityManagerFactoryBean not being exposed to ApplicationContext. The latter is an important bean since it enables exception translation. Original pull request: #180.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the PR is trivial so I didn't read the agreement, hope that it's fine)
Previously EntityManagerFactory was created manually which resulted in
LocalContainerEntityManagerFactoryBeannot being exposed toApplicationContext. The latter is an important bean since it enables
exception translation.
The fact that factory bean implements additional mechanisms is probably
a mistake in the design. But I guess we have to live with this now.