Fix positionFunction created by ScrollDelegate#3000
Closed
quaff wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix positionFunction created by ScrollDelegate#3000quaff wants to merge 1 commit intospring-projects:mainfrom
quaff wants to merge 1 commit intospring-projects:mainfrom
Conversation
Before this commit, positionFunction created by ScrollDelegate retains incorrect state when perform backward scrolling. 1. We must use window.positionAt(1) instead of window.positionAt(0) if we want position at the begin of window, we should call getResultWindow() first. 2. The direction always be FORWARD, it should be BACKWARD if the original direction is BACKWARD. Closes spring-projectsGH-2999
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
It covered by #3013 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes GH-2999