Skip to content

Conversation

@dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 23, 2024

This PR is expected to improve code readability by using the Assert.state() method.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 23, 2024
@dukbong dukbong changed the title Use Assert.state & Remove unnecessary operations with lazy evaluation. Use Assert.state improve code readability Apr 23, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 25, 2024
mp911de pushed a commit that referenced this pull request Apr 25, 2024
mp911de added a commit that referenced this pull request Apr 25, 2024
Invert condition to trigger exception.

See #3442
mp911de pushed a commit that referenced this pull request Apr 25, 2024
mp911de added a commit that referenced this pull request Apr 25, 2024
Invert condition to trigger exception.

See #3442
@mp911de mp911de closed this in 141d1ed Apr 25, 2024
mp911de added a commit that referenced this pull request Apr 25, 2024
Invert condition to trigger exception.

See #3442
@mp911de
Copy link
Member

mp911de commented Apr 25, 2024

Thank you for your contribution. That's merged, fixed, polished, and backported now.

Assert method usage triggers exceptions if the condition evaluates to false. That has required to flip the condition. Please mind running tests/the build before submitting a pull request.

@mp911de mp911de added this to the 3.1.12 (2023.0.12) milestone Apr 25, 2024
@dukbong dukbong deleted the LazyEvaluation branch April 25, 2024 09:11
@dukbong dukbong restored the LazyEvaluation branch April 25, 2024 09:35
@dukbong
Copy link
Contributor Author

dukbong commented Apr 25, 2024

Thank you for your contribution. That's merged, fixed, polished, and backported now.

I'm so sorry....
I will make testing a habit to avoid such incidents in the future.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants