Skip to content

Fix parsing entity names in JPQL query with package names that contain reserved words #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

christophstrobl
Copy link
Member

Resolves: #3451

@christophstrobl christophstrobl marked this pull request as ready for review April 29, 2024 11:27
@mp911de mp911de added the type: bug A general bug label Apr 29, 2024
@jgooley-sh
Copy link

Not sure if this PR handles the reserved words anywhere in the query, but I found that the table alias couldn't be the reserved word either.

select exp
from Experience exp

@mp911de
Copy link
Member

mp911de commented Apr 30, 2024

Not sure if this PR handles the reserved words anywhere in the query, but I found that the table alias couldn't be the reserved word either.

It isn't intended but permits reserved words as per JPA spec, identifiers are:

Reserved identifiers must not be used as identification variables or result variables

Isn't the purpose of reserved words that you cannot use these in arbitrary places?

@mp911de mp911de added this to the 3.1.12 (2023.0.12) milestone Apr 30, 2024
mp911de pushed a commit that referenced this pull request Apr 30, 2024
…n reserved words.

Resolves: #3451
Original pull request: #3457
mp911de pushed a commit that referenced this pull request Apr 30, 2024
… reserved exp keyword.

Resolves: #3451
Original pull request: #3457
mp911de added a commit that referenced this pull request Apr 30, 2024
…n reserved words.

Resolves: #3451
Original pull request: #3457
mp911de pushed a commit that referenced this pull request Apr 30, 2024
…n reserved words.

Resolves: #3451
Original pull request: #3457
mp911de pushed a commit that referenced this pull request Apr 30, 2024
… reserved exp keyword.

Resolves: #3451
Original pull request: #3457
mp911de added a commit that referenced this pull request Apr 30, 2024
…n reserved words.

Resolves: #3451
Original pull request: #3457
mp911de pushed a commit that referenced this pull request Apr 30, 2024
…n reserved words.

Resolves: #3451
Original pull request: #3457
mp911de pushed a commit that referenced this pull request Apr 30, 2024
… reserved exp keyword.

Resolves: #3451
Original pull request: #3457
@mp911de mp911de closed this Apr 30, 2024
@mp911de mp911de deleted the issue/3451 branch April 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JPQL and HQL parser issue with class projection when FQDN includes "exp"
3 participants