GH-3864: Add support for Set-Returning Functions (SRF) in HQL parser #3866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, an implentation for my issue #3864 ,
I used the sample project provided in the issue description (#3864) as a base to build and validate the integration tests with SRF support.
Details
-- Introduced grammar rules for set-returning functions in FROM and JOIN clauses.
-- Updated HqlQueryRenderer to support SRF syntax.
-- Added support for SRF in For count and sort.
-- Implemented QueryRenderer logic for proper spacing in function parameter rendering.
-- Added internal tests to verify SRF parsing and rendering logic.
Notes
This is my first contribution to the Spring Data project. I'm open to feedback and happy to make any necessary adjustments or improvements.
To run the tests locally, I had to:
org.hamcrest:hamcrest
to resolve aNoClassDefFoundError
.HqlParserUnitTests
, as the ANTLR-generated parser class is always created aspublic
, causing a mismatch with the expectedpackage-private
visibility.These changes were not committed, as I assumed they are specific to my local environment and not required for others.
Thanks for reviewing!