-
Notifications
You must be signed in to change notification settings - Fork 1.5k
DATAJPA-1827 - Consider wrapper types for Modifying JPA Query Execution #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now consider wrapper types (nullable types, Vavr/Javaslang/Futures) as potential wrappers and inspect the component type of each wrapper to determine the actual method return type.
Use ClassUtils.isAssignable(…) to simplify boxed/primitive assignability checks.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
We now consider wrapper types (nullable types, Vavr/Javaslang/Futures) as potential wrappers and inspect the component type of each wrapper to determine the actual method return type. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Use ClassUtils.isAssignable(…) to simplify boxed/primitive assignability checks. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
We now consider wrapper types (nullable types, Vavr/Javaslang/Futures) as potential wrappers and inspect the component type of each wrapper to determine the actual method return type. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Use ClassUtils.isAssignable(…) to simplify boxed/primitive assignability checks. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
We now consider wrapper types (nullable types, Vavr/Javaslang/Futures) as potential wrappers and inspect the component type of each wrapper to determine the actual method return type. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Use ClassUtils.isAssignable(…) to simplify boxed/primitive assignability checks. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
We now consider wrapper types (nullable types, Vavr/Javaslang/Futures) as potential wrappers and inspect the component type of each wrapper to determine the actual method return type. Original pull request: #438.
schauder
pushed a commit
that referenced
this pull request
Dec 11, 2020
Use ClassUtils.isAssignable(…) to simplify boxed/primitive assignability checks. Original pull request: #438.
That's merged. |
schauder
added a commit
that referenced
this pull request
Dec 11, 2020
Fixing tests. Original pull request: #438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now consider wrapper types (nullable types, Vavr/Javaslang/Futures) as potential wrappers and inspect the component type of each wrapper to determine the actual method return type.
Related ticket: DATAJPA-1827