Skip to content

Provide deleted object to KeyValueTemplate instead of deleting entities by Id #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue May 19, 2022 · 0 comments
Closed

Provide deleted object to KeyValueTemplate instead of deleting entities by Id #438

mp911de opened this issue May 19, 2022 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
2.7.1 (2021.2.1)

Comments

@mp911de
Copy link
Member

mp911de commented May 19, 2022

When deleting an entity through delete(T), we should call the appropriate delete by entity method on the KeyValueTemplate to retain as much context as possible. In Spring Vault we want to access the @Version property of an entity during removal to delete the exact version.
@mp911de mp911de added the type: enhancement A general enhancement label May 19, 2022
@mp911de mp911de added this to the 2.7.1 (2021.2.1) milestone May 19, 2022
mp911de added a commit that referenced this issue May 19, 2022
@mp911de
Provide deleted object to KeyValueTemplate instead of deleting enti…
866668f 
…ties by Id.

Closes #438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.7.1 (2021.2.1)
Development

No branches or pull requests
1 participant
@mp911de