Skip to content

Change findById(…) assert message to reflect the actual operation #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

AbassAdeyemi
Copy link
Contributor

@AbassAdeyemi AbassAdeyemi commented Jan 12, 2021

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-issuemaster
Copy link

@AbassAdeyemi Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2021
@AbassAdeyemi AbassAdeyemi changed the title Changes error message to a more beffiting one. Changes error message to a more befitting one. Jan 12, 2021
@mp911de
Copy link
Member

mp911de commented Jan 12, 2021

@pivotal-issuemaster This is an Obvious Fix

@pivotal-issuemaster
Copy link

@AbassAdeyemi This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@mp911de mp911de self-assigned this Jan 12, 2021
@AbassAdeyemi
Copy link
Contributor Author

AbassAdeyemi commented Jan 12, 2021 via email

@mp911de
Copy link
Member

mp911de commented Jan 12, 2021

Thanks a lot. No further action is required, I need to merge this PR tomorrow or so.

@mp911de mp911de added this to the 2.2.13 (Moore SR13) milestone Jan 13, 2021
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2021
@mp911de mp911de merged commit c14bad7 into spring-projects:master Jan 13, 2021
mp911de pushed a commit that referenced this pull request Jan 13, 2021
mp911de pushed a commit that referenced this pull request Jan 13, 2021
mp911de pushed a commit that referenced this pull request Jan 13, 2021
@mp911de mp911de changed the title Changes error message to a more befitting one. Change findById(…) assert message to reflect the actual operation Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants