Skip to content

Skip output for @Aggregation query methods using $out or void methods #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
diptanil-das opened this issue Jun 17, 2022 · 1 comment
Closed

Skip output for @Aggregation query methods using $out or void methods #4088

diptanil-das opened this issue Jun 17, 2022 · 1 comment
Assignees
@christophstrobl
Labels
type: enhancement A general enhancement
Milestone
4.0.5 (2022.0.5)

Comments

@diptanil-das
Copy link

Trying to run an Aggregation which has $out at the end. $out put outputs millions of records, the repository tires to map it and fails with a heap error. I don't need the output at all
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 17, 2022
@mp911de
Copy link
Member

mp911de commented Jun 20, 2022

We could determine the skipOutput flag from the method declaration in combination with whether the last stage is a $out stage. We don't need to update the @Meta annotation in consequence.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 20, 2022
christophstrobl added a commit that referenced this issue Mar 22, 2023
@christophstrobl
SkipOutput for void methods using declarative Aggregations having $ou…
c237136 
…t stage.

We now set the skipOutput flag if an annotated Aggregation defines an $out stage and when the method is declared to return no result (void / Mono<Void>, kotlin.Unit)

Closes: #4088
@christophstrobl christophstrobl mentioned this issue Mar 22, 2023
Closed
christophstrobl added a commit that referenced this issue Mar 22, 2023
@christophstrobl
SkipOutput for void methods using declarative Aggregations having $ou…
286b2b4 
…t stage.

We now set the skipOutput flag if an annotated Aggregation defines an $out stage and when the method is declared to return no result (void / Mono<Void>, kotlin.Unit)

Closes: #4088
@mp911de mp911de changed the title Kindly add skipOutput functionality to @Meta for use with @Aggregation Skip output for @Aggregation query methods using $out or void methods Apr 14, 2023
@mp911de mp911de added this to the 4.0.5 (2022.0.5) milestone Apr 14, 2023
mp911de pushed a commit that referenced this issue Apr 14, 2023
@christophstrobl @mp911de
Skip output for void methods using declarative Aggregations having …
68b4a09 
…`$out` stage.

We now set the skipOutput flag if an annotated Aggregation defines an $out stage and when the method is declared to return no result (void / Mono<Void>, kotlin.Unit)

Closes: #4088
Original pull request: #4341
mp911de added a commit that referenced this issue Apr 14, 2023
@mp911de
Polishing.
a5f7385 
Reformat code. Remove unused fields, modifiers and documentation artifacts.

See #4088
Original pull request: #4341
mp911de added a commit that referenced this issue Apr 14, 2023
@mp911de
Polishing.
a94ea17 
Reformat code. Remove unused fields, modifiers and documentation artifacts.

See #4088
Original pull request: #4341
@sbernardo sbernardo mentioned this issue Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.0.5 (2022.0.5)
4 participants
@mp911de @christophstrobl @spring-projects-issues @diptanil-das