Add support for collection expiration to @TimeSeries. #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bpfoster Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@bpfoster Thank you for signing the Contributor License Agreement! |
|
Thank you @bpfoster! To avoid the duplication in parsing the duration we're waiting for spring-projects/spring-framework#22474 to land in Framework 6 before bringing the changes in. Thanks for your understanding and patience. |
christophstrobl
added
status: on-hold
mp911de
added
status: blocked
|
Update - there's a PR (spring-projects/spring-framework#30396) targeting FW 6.1 timeframe. |
christophstrobl
removed
the
status: blocked
christophstrobl
added a commit
that referenced
this pull request
Sep 6, 2024
Switch to Spring Framework duration formatting. Favour expireAfter with string parameter over the seconds based variant. Deprecate the existing expireAfterSeconds attribute of the Indexed annotation. Consider property value syntax when parsing timeout expressions. Remove DurationStyle (package visible). Update documentation. Original Pull Request: #4114
|
Thank you @bpfoster for the contribution and your patience. Merged to main development line. |
christophstrobl
added a commit
that referenced
this pull request
Sep 6, 2024
Original Pull Request: #4114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow setting up automatic removal for time series collections (https://www.mongodb.com/docs/manual/core/timeseries/timeseries-automatic-removal/#set-up-automatic-removal-for-time-series-collections--ttl-), by adding an
expireAfterSecondsorexpireelement to the@TimeSeriesannotation.Similar to
@Indexed,expireAfterSecondson will have a default of-1, and will not be used if it is <= 0. An error will be thrown if bothexpireAterSecondsandexpireare defined.expireallows all the same expressions as are supported on@Indexed.Closes #4099