Skip to content

Adding support for InsertManyOptions for insert and insertAll methods #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Adding support for InsertManyOptions for insert and insertAll methods #4266

wants to merge 3 commits into from

Conversation

infoShare
Copy link

Adding support for InsertManyOptions for insert and insertAll methods on ReactiveMongoTemplate and MongoTemplate
Using writer on MongoTemplate.doInsertAll (which wasn't used)
Closes #4252

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

… on ReactiveMongoTemplate and MongoTemplate

Using writer on MongoTemplate.doInsertAll (which wasn't used)

Closes #4252
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 9, 2023
@christophstrobl
Copy link
Member

Thanks for taking the time to craft the PR. Would you please mind to remove the modifications (eg. changed imports) unrelated to the actual change. Thank you!

@christophstrobl christophstrobl self-assigned this Jan 16, 2023
@christophstrobl christophstrobl added the status: waiting-for-feedback We need additional information before we can continue label Jan 16, 2023
Tomasz Forys added 2 commits January 16, 2023 14:06
@infoShare infoShare closed this Jan 16, 2023
@infoShare
Copy link
Author

Clean PR created @christophstrobl - Cleanup import was checked by mistake on commit

#4273

@infoShare infoShare deleted the feature/IndexManyOptions-#4252 branch January 16, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding options parameter to ReactiveMongoTemplate.insertAll
3 participants