Allow reading already resolved DBRef values. #4323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to read (eg. by an aggregation $lookup) already fully resolved references between documents. No proxy will be created for lazy loading references and we'll also skip the additional server roundtrip to load the reference by its id.
mp911de
pushed a commit
that referenced
this pull request
Mar 15, 2023
This commit adds the ability to read (eg. by an aggregation $lookup) already fully resolved references between documents. No proxy will be created for lazy loading references and we'll also skip the additional server roundtrip to load the reference by its id. Closes #4312 Original pull request: #4323
mp911de
pushed a commit
that referenced
this pull request
Mar 15, 2023
This commit adds the ability to read (eg. by an aggregation $lookup) already fully resolved references between documents. No proxy will be created for lazy loading references and we'll also skip the additional server roundtrip to load the reference by its id. Closes #4312 Original pull request: #4323
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to read (eg. by an aggregation
$lookupstage) already fully resolved references between documents.No proxy will be created for lazy loading references and we'll also skip the additional server roundtrip to load the reference by its
_id.The change only effects usage of
@DBRefand does not change handling of@DocumentReferencewhich do not have a dedicated type that would allow to distinguish between already resolved and raw references.Since this is changing the behaviour of how we deal with
DBRefs I'd keep it on main for the time being and not back port it to any of the maintenance branches.Closes: #4312