Validate String based aggregation on query method creation. #4547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure to fail early if an annotated string based annotation does not contain a syntactically valid pipeline.
mp911de
reviewed
Nov 6, 2023
| @@ -504,6 +504,16 @@ public void verify() { | |||
| } | |||
| } | |||
| } | |||
| if (hasAnnotatedAggregation()) { | |||
| for (String stage : getAnnotatedAggregation()) { | |||
There was a problem hiding this comment.
How about using ParameterBindingJsonReader to verify that each declaration contains a single object?
There was a problem hiding this comment.
The QueryMethod itself does at this point not know about any parameters nor the parser to use so any validation attempt would be quite error prone due to the potential, non resolvable placeholders contained in the source string.
However there's BsonUtils#isJsonArray which we might want to reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #4546