Skip to content

Shard key not honored in ReferenceLookupDelegate when DocumentReference resolves to an empty collection #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Shard key not honored in ReferenceLookupDelegate when DocumentReference resolves to an empty collection #4613

wants to merge 1 commit into from

Conversation

stefanbildl
Copy link
Contributor

@stefanbildl stefanbildl commented Jan 12, 2024 •
edited
Loading

Fixes #4612

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@stefanbildl Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@stefanbildl Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2024
@mp911de mp911de changed the title fix: Shard key not honored in ReferenceLookupDelegate when DocumentReference resolves to an empty collection Shard key not honored in ReferenceLookupDelegate when DocumentReference resolves to an empty collection Apr 11, 2024
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@stefanbildl @mp911de
Skip reference lookup when DocumentReference resolves to an empty col…
521fcb1 
…lection.

Fixes #4612
Original pull request: #4613
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@christophstrobl @mp911de
Polishing.
dd9f0bc 
Wrap no results predicate in dedicated lookup filter and make sure to omit loading attempt also for map properties.

See #4612
Original pull request: #4613
mp911de added a commit that referenced this pull request Apr 11, 2024
@mp911de
Polishing.
49a3be6 
Add Override annotations and comment why we optimize.

See #4612
Original pull request: #4613
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@stefanbildl @mp911de
Skip reference lookup when DocumentReference resolves to an empty col…
4ec995f 
…lection.

Fixes #4612
Original pull request: #4613
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@christophstrobl @mp911de
Polishing.
e239745 
Wrap no results predicate in dedicated lookup filter and make sure to omit loading attempt also for map properties.

See #4612
Original pull request: #4613
mp911de added a commit that referenced this pull request Apr 11, 2024
@mp911de
Polishing.
37dae78 
Add Override annotations and comment why we optimize.

See #4612
Original pull request: #4613
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 11, 2024
@mp911de mp911de added this to the 4.2.5 (2023.1.5) milestone Apr 11, 2024
@mp911de
Copy link
Member

mp911de commented Apr 11, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Apr 11, 2024
@stefanbildl
Copy link
Contributor Author

Thank you!

natedanner pushed a commit to natedanner/spring-projects__spring-data-mongodb that referenced this pull request May 20, 2024
@stefanbildl
Skip reference lookup when DocumentReference resolves to an empty col…
18025c1 
…lection.

Fixes spring-projects#4612
Original pull request: spring-projects#4613
natedanner pushed a commit to natedanner/spring-projects__spring-data-mongodb that referenced this pull request May 20, 2024
@christophstrobl
Polishing.
ea73383 
Wrap no results predicate in dedicated lookup filter and make sure to omit loading attempt also for map properties.

See spring-projects#4612
Original pull request: spring-projects#4613
natedanner pushed a commit to natedanner/spring-projects__spring-data-mongodb that referenced this pull request May 20, 2024
@mp911de
Polishing.
2913831 
Add Override annotations and comment why we optimize.

See spring-projects#4612
Original pull request: spring-projects#4613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
4.2.5 (2023.1.5)
Development

Successfully merging this pull request may close these issues.

Shard key not honored in ReferenceLookupDelegate when DocumentReference resolves to a empty collection
4 participants
@stefanbildl @pivotal-cla @mp911de @spring-projects-issues