DATAMONGO-1836 - Add support to hint in aggregation options. #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thekaleidoscope
commented
Jul 19, 2020
thekaleidoscope
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
|
Thanks a lot. Care to add the hint implementation to |
…emplate. Add support to aggregateAndMap of ReactiveMongoTemplate which is called by aggregation methods internally.
|
@mp911de Hi, Thanks for catching it, Missed it somehow. Pushed the changes. On an unrelated note, the code of conduct page is down. |
|
Thanks for your contribution. We're going to take this pull request from here. The Code of Conduct issue is now resolved. |
mp911de
added a commit
that referenced
this pull request
Aug 6, 2020
Revert constructor change of AggregationOptions to not break existing code. Update since tags. Reformat code. Align visibility of AggregationOptionsTests with JUnit 5 rules. Update documentation. Original pull request: #878.
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.