Refactor Jedis and Lettuce RedisConnectionFactory to SmartLifecycle beans
#2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Jul 4, 2023
| @@ -415,6 +460,8 @@ protected JedisCluster createCluster(RedisClusterConfiguration clusterConfig, | |||
|
|
|||
| public void destroy() { | |||
|
|
|||
| state.set(State.STOPPING); | |||
There was a problem hiding this comment.
Would it make sense to call stop as we have quite some duplications?
mp911de
reviewed
Jul 4, 2023
| Assert.state(this.initialized, "JedisConnectionFactory was not initialized through afterPropertiesSet()"); | ||
| Assert.state(!this.destroyed, "JedisConnectionFactory was destroyed and cannot be used anymore"); | ||
| Assert.state(State.STARTED.equals(state.get()), "JedisConnectionFactory was not initialized through afterPropertiesSet()"); | ||
| Assert.state(!State.STOPPED.equals(state.get()), "JedisConnectionFactory was destroyed and cannot be used anymore"); |
There was a problem hiding this comment.
We might want to reflect the lifecycle in the messages, as we want to allow starting after stopping, right?
mp911de
reviewed
Jul 4, 2023
| resetConnection(); | ||
| dispose(connectionProvider); | ||
| dispose(reactiveConnectionProvider); | ||
| this.client.close(); |
There was a problem hiding this comment.
we should consider the shutdown timeout to prevent long shutdown times.
mp911de
reviewed
Jul 4, 2023
| Duration timeout = clientConfiguration.getShutdownTimeout(); | ||
| client.shutdown(quietPeriod.toMillis(), timeout.toMillis(), TimeUnit.MILLISECONDS); | ||
| } catch (Exception e) { | ||
| try { |
There was a problem hiding this comment.
That code could go into stop and upon destroy it would be neat to reuse what stop does.
mp911de
reviewed
Jul 4, 2023
| } | ||
| state.set(State.DESTROYED); |
mp911de
reviewed
Jul 4, 2023
|
|
||
| Assert.state(State.STARTED.equals(state.get()), | ||
| "LettuceConnectionFactory was not initialized through afterPropertiesSet()"); | ||
| Assert.state(!State.STOPPED.equals(state.get()), |
There was a problem hiding this comment.
We should reword the messages to reflect started/stopped state. Having a check for destroyed it good as well.
mp911de
changed the title
RedisConnectionFactory to SmartLifecycle beans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2503