Skip to content

Add getFirst(K key) and getLast(K key) methods to ListOperations #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add getFirst(K key) and getLast(K key) methods to ListOperations #2966

wants to merge 1 commit into from

Conversation

violetbeach
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

resolved #2937

@violetbeach violetbeach changed the title Add getFirst(K key), getLast(K key) methods Add getFirst(K key), getLast(K key) methods to ListOperations Aug 13, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 13, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 19, 2024
@mp911de mp911de self-assigned this Aug 19, 2024
@mp911de mp911de added this to the 3.4 M1 (2024.1.0) milestone Aug 20, 2024
@mp911de mp911de changed the title Add getFirst(K key), getLast(K key) methods to ListOperations Add getFirst(K key) and getLast(K key) methods to ListOperations Aug 20, 2024
mp911de pushed a commit that referenced this pull request Aug 20, 2024
@violetbeach @mp911de
Add getFirst(K key) and getLast(K key) methods to ListOperations.
a58bfd8 
Original pull request: #2966
Closes #2937
mp911de added a commit that referenced this pull request Aug 20, 2024
@mp911de
Polishing.
bd20c6d 
Add getFirst/getLast to Reactive and Bound Operations.

Simplify getLast implementation.

Reorder methods, tweak Javadoc, add since tags.

Original pull request: #2966
See #2937
@mp911de
Copy link
Member

mp911de commented Aug 20, 2024

Thank you for your contribution. That's merged, polished, and backported now. I simplified the getLast implementation, you might be interested in the polishing commit at bd20c6d.

@mp911de mp911de closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 M1 (2024.1.0)
Development

Successfully merging this pull request may close these issues.

Add getFirst(K key), getLast(K key) methods like Java 21
3 participants
@violetbeach @mp911de @spring-projects-issues