StompSubProtocolHandler makes the same assumption about header accessor as SimpleBrokerMessageHandler used to [SPR-14791]

[spring-projects-issues]

Dave Syer opened SPR-14791 and commented

Just like in #18851, StompSubProtocolHandler.getStompHeaderAccessor() makes an assumption about the content of the Message it is processing. In particular, it assumes that there is a MessageHeaderAccessor, but that isn't necessarily the case, for instance if the user has added a ChannelInterceptor that rebuilds the message and adds some headers by calling MessageBuilder.fromMessage(...).build().

---

Affects: 4.2.8, 4.3.3

Issue Links:

• SimpleBrokerMessageHandler makes an assertion about the type of the MessageHeaderAccessor, but doesn't seem to care [SPR-14279] #18851 SimpleBrokerMessageHandler makes an assertion about the type of the MessageHeaderAccessor, but doesn't seem to care

Referenced from: commits f5cd538, aff5d21, 66722af

Backported to: 4.2.9

[spring-projects-issues]

Dave Syer commented

We found a workaround in Spring Sleuth spring-cloud/spring-cloud-sleuth#276. I guess we can still consider this a valid improvement.