MockMvc async does not re-use response instance on async dispatch [SPR-16067]

[spring-projects-issues]

Lukas Krecan opened SPR-16067 and commented

I have a MockMvc test for testing controller with deferred result. It works nice, unit the moment I add ShallowEtagFilter which assumes that the response from the async start request is kept for the following processing. MockMvc.perform always creates new MockHttpServletResponse which causes ShallowEtagFilter to fail. Please, see this demo project for details https://github.com/lukas-krecan-lt/async-demo

---

Affects: 4.3.11

Reference URL: https://github.com/lukas-krecan-lt/async-demo/blob/master/src/test/java/com/example/asyncdemo/AsyncControllerTest.java

Issue Links:

• MockMvc error handling with CompletableFuture regression in 5.0.1+ [SPR-16430] #20976 MockMvc error handling with CompletableFuture regression in 5.0.1+

Referenced from: commits cd63463

[spring-projects-issues]

Rossen Stoyanchev commented

I imagine in most cases the response isn't modified until the async dispatch, which explains why no one ever raised this as an issue. That said re-using the response would be more aligned with how it works inside a Servlet container.

[spring-projects-issues]

Rossen Stoyanchev commented

There is now a fix in master.