Incorrect SpEL syntax in reference documentation [SPR-16315]

[spring-projects-issues]

Sviatoslav Hryb opened SPR-16315 and commented

Spring Framework Reference (Testing) https://docs.spring.io/spring/docs/5.0.2.RELEASE/spring-framework-reference/testing.html contains incorrect code fragment in section 3.5.6. Testing request and session scoped beans

The incorrect fragment is:

<beans>

    <bean id="userService"
            class="com.example.SimpleUserService"
            c:loginAction-ref="loginAction" />

    <bean id="loginAction" class="com.example.LoginAction"
            c:username="{request.getParameter('user')}"
            c:password="{request.getParameter('pswd')}"
            scope="request">
        <aop:scoped-proxy />
    </bean>

</beans>

The problem is that c:username="{request.getParameter('user')}" should have prefix #{ for correct SpEL syntax. The same is true for c:password="{request.getParameter('pswd')}"

---

Affects: 4.3.13, 5.0.2

Referenced from: commits 8aa94ae, 0d151b0

Backported to: 4.3.14

[spring-projects-issues]

Juergen Hoeller commented

Stéphane Nicoll, this seems to be an escaping problem... Any insight into asciidoc's behavior here?

Oddly enough, we were only escaping the '#' character in the first case before. Removing that escape sequence made the character disappear in three places now, also in the session.getAttribute('theme') example further below.

[spring-projects-issues]

Stéphane Nicoll commented

That block was using verbatim substitution but there was no need to do that. I've removed it and the code snippet is fine now. Also backported to 4.3.x.

[spring-projects-issues]

Sam Brannen commented

Oops!

I thought I fixed that in this commit, but obviously I did not.

Thanks, Stéphane Nicoll!