Skip to content

Upgrade to spring-javaformat-checkstyle 0.0.28 and downgrade to Checkstyle 8.41 #27481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbrannen opened this issue Sep 28, 2021 · 0 comments
Closed
Assignees
Labels
type: task A general task
Milestone

Comments

@sbrannen
Copy link
Member

In order to be able to use text blocks and other new Java language features, we should upgrade to a recent version of Checkstyle.

The latest version of spring-javaformat-checkstyle (0.0.28) is built against Checkstyle 8.32 which does not include support for language features such as text blocks. Support for text blocks was added in Checkstyle 8.36.

In addition, there is a binary compatibility issue between spring-javaformat-checkstyle 0.0.28 and Checkstyle 8.42.

Thus we cannot use Checkstyle 8.45.1.

We therefore need to upgrade to spring-javaformat-checkstyle 0.0.28 and downgrade to Checkstyle 8.41.

This change will be applied to 5.3.x as well as main in order to benefit from the enhanced checking provided in more recent versions of Checkstyle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant