SPR-11587: Support multiple TilesContainer per ServletContext #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use explicit containerKey derived from the contextId to register TilesContainer to be able to use multiple definition unique to each WebApplicationContext (there maybe more than one in case of multiple DispatcherContext servlet registrations) Issue: SPR-11587
spring-projects-issues
added
the
status: waiting-for-triage
|
Closing since Tiles support has been dropped for 6.0 with #27423. |
rstoyanchev
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why i did this - because Spring fails to properly support multiple TilesContainer per ServletContext because its using a "null" key mapping, multiple container in different FrameworkServlets will override each others factory. See ticket for details.
Question to be answered:
Discussion in general:
Still need to polish it to the coding guidelines - but want to get early feedback on the general refactoring
stuf, if it fits your expectations or how todo it better.
Package visibility access on many properties is not my favourite - should i refactor those in getters or pass the needed references to each instance via construction parameters? Any other ideas?
ICLA submitted.
Issue: SPR-11587