-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Expose HttpHandler Decoration as a bean #26502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sp00m Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@sp00m Thank you for signing the Contributor License Agreement! |
Something like this would be fine. |
A couple of things I'll probably adjust. 1) we'd want to allow multiples of these, and 2) it should be named something other than Decorator for consistency with other such types in our web code which normally are implementations of the target type ( |
@rstoyanchev, thanks for the review, updated as proposed, let me know. |
import java.util.Collections; | ||
import java.util.concurrent.atomic.AtomicBoolean; | ||
import java.util.concurrent.atomic.AtomicLong; | ||
import java.util.function.BiFunction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, just noticed those modifications. IntelliJ reordered them on my behalf, let me know if you want me to revert them to reduce the diff. I use IntelliJ's default config FYI.
Follows the development that has been done for #25633.
Having the
httpHandlerDecorator
as a bean allows easier integration with Spring Boot, seeHttpHandlerAutoConfiguration
.I wasn't sure what version to put in
@since
Javadoc tags.Let me know what you think.