Skip to content

Fix @Scope documentation in ref docs #26773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hrybs
Copy link
Contributor

@hrybs hrybs commented Apr 7, 2021

Chapter 1. The IoC Container, section 1.12.3. Using the @Bean Annotation, paragraph Specifying Bean Scope of official documentation contains incorrect description of @Scope annotation.
The default value of proxyMode attribute is not ScopedProxyMode.NO but is ScopedProxyMode.DEFAULT which has absolutely different behaviour.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 7, 2021
Copy link

@cuspymd cuspymd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@hrybs hrybs force-pushed the Fix-Scope-annotation-description branch from ed20250 to a5b1fe3 Compare April 29, 2021 07:54
@hrybs hrybs changed the title fix scope annotation description Fix @Scope annotation Incorrect description Apr 29, 2021
@sbrannen sbrannen changed the title Fix @Scope annotation Incorrect description Fix @Scope documentation in ref docs Apr 29, 2021
@sbrannen sbrannen self-assigned this Apr 29, 2021
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 29, 2021
@sbrannen sbrannen added this to the 5.3.7 milestone Apr 29, 2021
@sbrannen sbrannen merged commit ae7d520 into spring-projects:main Apr 29, 2021
@sbrannen
Copy link
Member

This has been merged into main.

Thanks

lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants