-
Notifications
You must be signed in to change notification settings - Fork 472
Add profile property #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Fully support HAL spec by adding "profile" as another optional attribute to `Link`.
@DavidBiesack We don't wish to open up the visibility, so instead I've made an update to Link that I'll wait for @olivergierke to review and approve. |
thanks for the PR to add |
Link isn't reallly designed as an extension point to the project. In short you could fork and work from that. |
Fully support HAL spec by adding "profile" as another optional attribute to `Link`. See: https://tools.ietf.org/html/draft-kelly-json-hal-08
Fully support HAL spec by adding "profile" as another optional attribute to `Link`. See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
Fully support HAL spec by adding "profile" as another optional attribute to `Link`. See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
Moved compilation of Regexp patterns out of methods in order to not repeat it over and over again. Applied soft assertions where multiple assertions where used where one failure didn't guarantee the failure of all other assertions. Minor formatting.
Fully support HAL spec by adding "profile" as another optional attribute to `Link`. See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
* Moved compilation of Regexp patterns out of methods in order to not repeat it over and over again. * Applied soft assertions where multiple assertions where used where one failure didn't guarantee the failure of all other assertions. * Minor formatting.
Resolved via 6f27ff0. |
draft-kelly-json-hal-08 JSON HAL defines the optional string
profile
member which is not implemented inorg.springframework.hateoas.Link
. The profile field was requested in #656 but not implemented in 0.24.RELEASE. Please add it.(As an aside, advice on how to extend the
org.springframework.hateoas.Link
class would be welcome. Lombok makes this pretty hard, since the@AllConstructor
is package protected and not callable from the subclass. Without access to thatsuper(...)
constructor, I don't see a way to extendLink
and add the field - there are no setters, only@Wither
members which do not clone the subclass object but call aorg.springframework.hateoas.Link1
constructor. Perhaps another enhancement would be to removeAccessLevel.PACKAGE
)The text was updated successfully, but these errors were encountered: