Skip to content

Add profile property #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidBiesack opened this issue Dec 6, 2017 · 4 comments
Closed

Add profile property #678

DavidBiesack opened this issue Dec 6, 2017 · 4 comments
Assignees
Milestone

Comments

@DavidBiesack
Copy link

DavidBiesack commented Dec 6, 2017

draft-kelly-json-hal-08 JSON HAL defines the optional string profile member which is not implemented in org.springframework.hateoas.Link. The profile field was requested in #656 but not implemented in 0.24.RELEASE. Please add it.

(As an aside, advice on how to extend the org.springframework.hateoas.Link class would be welcome. Lombok makes this pretty hard, since the @AllConstructor is package protected and not callable from the subclass. Without access to that super(...) constructor, I don't see a way to extend Link and add the field - there are no setters, only @Wither members which do not clone the subclass object but call a org.springframework.hateoas.Link1 constructor. Perhaps another enhancement would be to remove AccessLevel.PACKAGE )

@DavidBiesack DavidBiesack changed the title Add profile member Add profile property Dec 6, 2017
gregturn added a commit that referenced this issue Dec 7, 2017
Fully support HAL spec by adding "profile" as another optional attribute to `Link`.
@gregturn gregturn assigned gregturn and odrotbohm and unassigned gregturn and odrotbohm Dec 7, 2017
@gregturn
Copy link
Contributor

gregturn commented Dec 7, 2017

@DavidBiesack We don't wish to open up the visibility, so instead I've made an update to Link that I'll wait for @olivergierke to review and approve.

@DavidBiesack
Copy link
Author

thanks for the PR to add profile. Since you have elected to not widen the scope of the constructor, is there some other way that one can subclass Link to add new fields?

@gregturn
Copy link
Contributor

gregturn commented Dec 7, 2017

Link isn't reallly designed as an extension point to the project. In short you could fork and work from that.

gregturn added a commit that referenced this issue Dec 6, 2018
Fully support HAL spec by adding "profile" as another optional attribute to `Link`.

See: https://tools.ietf.org/html/draft-kelly-json-hal-08
gregturn added a commit that referenced this issue Dec 6, 2018
Fully support HAL spec by adding "profile" as another optional attribute to `Link`.

See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
gregturn added a commit that referenced this issue Dec 6, 2018
Fully support HAL spec by adding "profile" as another optional attribute to `Link`.

See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
schauder added a commit that referenced this issue Dec 7, 2018
Moved compilation of Regexp patterns out of methods in order to not repeat it over and over again.
Applied soft assertions where multiple assertions where used where one failure didn't guarantee the failure of all other assertions.

Minor formatting.
gregturn added a commit that referenced this issue Dec 7, 2018
Fully support HAL spec by adding "profile" as another optional attribute to `Link`.

See: https://tools.ietf.org/html/draft-kelly-json-hal-08, https://tools.ietf.org/html/rfc5988
gregturn pushed a commit that referenced this issue Dec 7, 2018
* Moved compilation of Regexp patterns out of methods in order to not repeat it over and over again.
* Applied soft assertions where multiple assertions where used where one failure didn't guarantee the failure of all other assertions.
* Minor formatting.
@gregturn
Copy link
Contributor

gregturn commented Dec 7, 2018

Resolved via 6f27ff0.

@gregturn gregturn closed this as completed Dec 7, 2018
@gregturn gregturn added this to the 1.0 M1 milestone Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants