Changed linkTo so that it can be invoked outside of a HttpRequest. #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed linkTo so that it can be invoked outside of a HttpRequest - issue spring-projects#408. Added linkTo method, which takes an explicit UriComponentBuilder.
odrotbohm
force-pushed
the
master
branch
2 times, most recently
from
4ebc1be to
266ad50
Compare
|
@nickgrealy This looks quite interesting. Do you think you could squash and rebase your PR against latest master? |
|
@nickgrealy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
I like the idea of being able to use linkTo outside of the request context, but seriously, relying on catching an IllegalStateException to proceed with the program flow cannot be the solution to it... |
gregturn
added a commit
that referenced
this pull request
May 25, 2017
gregturn
added a commit
that referenced
this pull request
May 25, 2017
gregturn
added a commit
that referenced
this pull request
May 25, 2017
gregturn
added a commit
that referenced
this pull request
May 25, 2017
odrotbohm
pushed a commit
that referenced
this pull request
Jul 27, 2017
odrotbohm
added a commit
that referenced
this pull request
Jul 27, 2017
|
Resolved via #408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed linkTo so that it can be invoked outside of a HttpRequest -
issue #408.
Added a linkTo method, which takes an explicit UriComponentBuilder.
I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.