Skip to content

Expose amqp_channel and amqp_deliveryTag headers in case message conversion fails #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ekazakas opened this issue Feb 1, 2019 · 2 comments
Closed

Expose amqp_channel and amqp_deliveryTag headers in case message conversion fails #2728

ekazakas opened this issue Feb 1, 2019 · 2 comments
Assignees
@garyrussell
Labels
in: amqp type: enhancement
Milestone
5.1.3

Comments

@ekazakas
Copy link

ekazakas commented Feb 1, 2019

Enhancement

Would it be possible to expose amqp_channel and amqp_deliveryTag headers to ErrorMessage in case message conversion fails?

This could be useful in scenarios when inbound adapter is configured with acknowledge mode = MANUAL.

At the moment these headers are only attached on Message, but since the conversion fails we don't have the Message object. And now it's impossible to reject the message anymore, since there is no way to track down the channel.

A workarround solution is to do message conversion in a transformer.
@garyrussell
Copy link
Contributor

See https://stackoverflow.com/questions/54439916/how-to-handle-errors-after-message-has-been-handed-off-to-queuechannel/54442657#54442657

Moving this to spring-integration.

@garyrussell garyrussell transferred this issue from spring-projects/spring-amqp Feb 1, 2019
@garyrussell garyrussell modified the milestone: 5.1.3 Feb 1, 2019
@garyrussell garyrussell added status: waiting-for-triage The issue need to be evaluated and its future decided and removed status: waiting-for-triage The issue need to be evaluated and its future decided labels Feb 1, 2019
@garyrussell garyrussell added this to the 5.1.3 milestone Feb 1, 2019
@garyrussell garyrussell self-assigned this Feb 1, 2019
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Feb 1, 2019
@garyrussell
spring-projectsGH-2728: AMQP Manual acks and conversion errors
4db48dd 
Resolves spring-projects#2728

Provide access to the channel and delivery tag in the `ErrorMessage` when
using `AcknowledgeMode.MANUAL`.
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Feb 1, 2019
@garyrussell
spring-projectsGH-2728: AMQP Manual acks and conversion errors
ec43b63 
Resolves spring-projects#2728

Provide access to the channel and delivery tag in the `ErrorMessage` when
using `AcknowledgeMode.MANUAL`.
@garyrussell garyrussell mentioned this issue Feb 1, 2019
Merged
artembilan pushed a commit that referenced this issue Feb 1, 2019
@garyrussell @artembilan
GH-2728: AMQP Manual acks and conversion errors
f82c716 
Resolves #2728

Provide access to the channel and delivery tag in the `ErrorMessage` when
using `AcknowledgeMode.MANUAL`.
@ekazakas
Copy link
Author

ekazakas commented Feb 4, 2019

Thanks Gary, that SO question was mine, sorry for not putting a reference. Looking forward to the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: amqp type: enhancement
Projects
None yet
Milestone
5.1.3
Development

No branches or pull requests
2 participants
@garyrussell @ekazakas