Skip to content

Consider to remove Guava dependency used only as optional in the StoredProcExecutor for caching #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
artembilan opened this issue Feb 15, 2019 · 0 comments · Fixed by #2766
Closed

Consider to remove Guava dependency used only as optional in the StoredProcExecutor for caching #2753

artembilan opened this issue Feb 15, 2019 · 0 comments · Fixed by #2766
Assignees
@artembilan
Milestone
5.2.M1

Comments

@artembilan
Copy link
Member

Looks like the provided caching capabilities (including stats) are just an overhead for such an internal logic of the Framework.
A simple LinkedHashMap with plain eviction policy is fully enough to achieve a functionality of the StoredProcExecutor component.
And that is used already by default.
@artembilan artembilan added this to the 5.2.M1 milestone Feb 15, 2019
@artembilan artembilan self-assigned this Feb 25, 2019
artembilan added a commit to artembilan/spring-integration that referenced this issue Feb 26, 2019
@artembilan
spring-projectsGH-2753: Remove Guava dependency
6804edf 
Fixes spring-projects#2753

* Remove Guava dependency and its minor functionality from the
`StoredProcExecutor`
* Remove `@ManagedResource` and its operations/attributes from
`StoredProcExecutor` since they are not relevant any more
* Remove tests related to JMX and Guava
* Refactor all other tests in the affected classes
* Some code polishing in the `StoredProcExecutor`
@artembilan artembilan mentioned this issue Feb 26, 2019
Merged
garyrussell pushed a commit that referenced this issue Mar 7, 2019
@artembilan @garyrussell
GH-2753: Remove Guava dependency
7efb14c 
Fixes #2753

* Remove Guava dependency and its minor functionality from the
`StoredProcExecutor`
* Remove `@ManagedResource` and its operations/attributes from
`StoredProcExecutor` since they are not relevant any more
* Remove tests related to JMX and Guava
* Refactor all other tests in the affected classes
* Some code polishing in the `StoredProcExecutor`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
None yet
Projects
None yet
Milestone
5.2.M1
Development

Successfully merging a pull request may close this issue.

GH-2753: Remove Guava dependency artembilan/spring-integration
1 participant
@artembilan