Skip to content

Add discard channel support for splitters #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alturkovic opened this issue Feb 25, 2019 · 1 comment · Fixed by #2883
Closed

Add discard channel support for splitters #2765

alturkovic opened this issue Feb 25, 2019 · 1 comment · Fixed by #2883
Assignees
@artembilan
Labels
in: core
Milestone
5.2.M1

Comments

@alturkovic
Copy link
Contributor

When encountering empty collections, splitter should be able to send the result to a discard channel. Currently, when encountering an empty collection, the splitter ends the flow. Some use-cases may rely on a custom split function which may returns empty collections. These use-cases should be able to define a discard channel so they can proceed with a possible compensation flow.
@artembilan
Copy link
Member

Only correction that we should discard a request message, not a result of split function. Something similar what we have with a filter or an aggregator.

@artembilan artembilan added this to the 5.2.M1 milestone Feb 25, 2019
@artembilan artembilan self-assigned this Feb 25, 2019
artembilan added a commit to artembilan/spring-integration that referenced this issue Apr 4, 2019
@artembilan
spring-projectsGH-2765: Add discardChannel for splitter
093753e 
Fixes spring-projects#2765

When encountering empty collections, splitter should be able to send
the result to a discard channel.
Currently, when encountering an empty collection,
the splitter ends the flow.
Some use-cases may rely on a custom split function which may returns
empty collections.
These use-cases should be able to define a discard channel
so they can proceed with a possible compensation flow.

* Add `discardChannel` option to the `AbstractMessageSplitter`
* Delegate `discardChannel` population from everywhere it is possible:
DSL, XML, `AbstractMessageSplitter` extension like `FileSplitter` etc.
* Fix `FileSplitterTests` for broken charset
* Document new feature; fix some typos and out-dated code sample
@artembilan artembilan mentioned this issue Apr 4, 2019
Merged
artembilan added a commit to artembilan/spring-integration that referenced this issue Apr 5, 2019
@artembilan
spring-projectsGH-2765: Add discardChannel for splitter
5ea3665 
Fixes spring-projects#2765

When encountering empty collections, splitter should be able to send
the result to a discard channel.
Currently, when encountering an empty collection,
the splitter ends the flow.
Some use-cases may rely on a custom split function which may returns
empty collections.
These use-cases should be able to define a discard channel
so they can proceed with a possible compensation flow.

* Add `discardChannel` option to the `AbstractMessageSplitter`
* Delegate `discardChannel` population from everywhere it is possible:
DSL, XML, `AbstractMessageSplitter` extension like `FileSplitter` etc.
* Fix `FileSplitterTests` for broken charset
* Document new feature; fix some typos and out-dated code sample
garyrussell pushed a commit that referenced this issue Apr 8, 2019
@artembilan @garyrussell
GH-2765: Add discardChannel for splitter (#2883)
818be4c 
* GH-2765: Add discardChannel for splitter

Fixes #2765

When encountering empty collections, splitter should be able to send
the result to a discard channel.
Currently, when encountering an empty collection,
the splitter ends the flow.
Some use-cases may rely on a custom split function which may returns
empty collections.
These use-cases should be able to define a discard channel
so they can proceed with a possible compensation flow.

* Add `discardChannel` option to the `AbstractMessageSplitter`
* Delegate `discardChannel` population from everywhere it is possible:
DSL, XML, `AbstractMessageSplitter` extension like `FileSplitter` etc.
* Fix `FileSplitterTests` for broken charset
* Document new feature; fix some typos and out-dated code sample

* * Fix `SplitterFactoryBean` for NPE on the `discardChannelName`
propagation

* * Check `this.discardChannel` first
* `Assert.state()` in `doInit()` for mutual exclusiveness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: core
Projects
None yet
Milestone
5.2.M1
Development

Successfully merging a pull request may close this issue.

GH-2765: Add discardChannel for splitter artembilan/spring-integration
2 participants
@artembilan @alturkovic