Skip to content

RedisUtils.isUnlinkAvailable bug #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sojw opened this issue Mar 29, 2019 · 0 comments
Closed

RedisUtils.isUnlinkAvailable bug #2868

sojw opened this issue Mar 29, 2019 · 0 comments
Assignees
@artembilan
Labels
in: redis type: bug
Milestone
5.2.M1

Comments

@sojw
Copy link

sojw commented Mar 29, 2019

Affects Version(s): \5.1.3

hi. there

we are upgrading to springboot 2.1.3.

since then, NE have occurred in the redis lock part of spring-integration.
we looked for the cause.

we have modified version of our redis server info and returned it.
ex) "111.111.111.111:7000.redis_version" -> "4.0.9"

If we handle this redis_version in the isUnlinkAvailable function, an NE occurs.
I think we need to fix this part.
If it does not fit in the pattern, try to return it as the default value by try / catch.

currently, we have downgraded to 5.1.2 and are running normally.
@artembilan artembilan added this to the 5.2.M1 milestone Mar 29, 2019
artembilan added a commit to artembilan/spring-integration that referenced this issue Mar 29, 2019
@artembilan
Fix RedisUtils.isUnlinkAvailable() for NPE
9a50fe8 
Fixes spring-projects#2868

If Redis version is not present in `x.x.x` pattern, fall back to the
`Integer.parseInt()` against returned `redis_version` property value

**Cherry-pick to 5.1.x**
@artembilan artembilan mentioned this issue Mar 29, 2019
Merged
artembilan added a commit to artembilan/spring-integration that referenced this issue Mar 29, 2019
@artembilan
Fix RedisUtils.isUnlinkAvailable() for NPE
fe08c1a 
Fixes spring-projects#2868

* Check if `redis_version` property is returned from the `info`
before parsing

**Cherry-pick to 5.1.x**
garyrussell pushed a commit that referenced this issue Mar 29, 2019
@artembilan @garyrussell
Fix RedisUtils.isUnlinkAvailable() for NPE
d944752 
Fixes #2868

* Check if `redis_version` property is returned from the `info`
before parsing

**Cherry-pick to 5.1.x**
garyrussell pushed a commit that referenced this issue Mar 29, 2019
@artembilan @garyrussell
Fix RedisUtils.isUnlinkAvailable() for NPE
659613c 
Fixes #2868

* Check if `redis_version` property is returned from the `info`
before parsing

**Cherry-pick to 5.1.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: redis type: bug
Projects
None yet
Milestone
5.2.M1
Development

No branches or pull requests
2 participants
@artembilan @sojw