Skip to content

Add generic source_message header #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garyrussell opened this issue Jun 10, 2019 · 0 comments · Fixed by #2959, #2961 or spring-attic/spring-integration-kafka#270
Closed

Add generic source_message header #2958

garyrussell opened this issue Jun 10, 2019 · 0 comments · Fixed by #2959, #2961 or spring-attic/spring-integration-kafka#270
Assignees
Milestone

Comments

@garyrussell
Copy link
Contributor

To allow streams app to always have access to the raw message regardless of whether or not retry is enabled.

@garyrussell garyrussell added this to the 5.1.6 milestone Jun 10, 2019
@garyrussell garyrussell self-assigned this Jun 10, 2019
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jun 10, 2019
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jun 10, 2019
artembilan pushed a commit that referenced this issue Jun 10, 2019
artembilan pushed a commit that referenced this issue Jun 10, 2019
Resolves #2958

# Conflicts:
#	spring-integration-amqp/src/main/java/org/springframework/integration/amqp/inbound/AmqpInboundChannelAdapter.java
#	spring-integration-amqp/src/main/java/org/springframework/integration/amqp/inbound/AmqpInboundGateway.java
#	spring-integration-amqp/src/test/java/org/springframework/integration/amqp/inbound/AmqpMessageSourceTests.java
#	spring-integration-amqp/src/test/java/org/springframework/integration/amqp/inbound/InboundEndpointTests.java
#	spring-integration-core/src/main/java/org/springframework/integration/IntegrationMessageHeaderAccessor.java
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jun 11, 2019
Resolves spring-projects#2958

The previous commit added the raw source message to a common header
`IntegrationMessageHeaderAccessor.SOURCE_DATA` so that the spring-cloud-stream
can construct an error message containing the data when using functions.

However, we also need to add it to the common header when the `ErrorMessage`
is created by Spring Integration for the normal message channel binder.

This allows the DLQ processing to be agnostic as to who created the
error message.
artembilan pushed a commit that referenced this issue Jun 11, 2019
Resolves #2958

The previous commit added the raw source message to a common header
`IntegrationMessageHeaderAccessor.SOURCE_DATA` so that the spring-cloud-stream
can construct an error message containing the data when using functions.

However, we also need to add it to the common header when the `ErrorMessage`
is created by Spring Integration for the normal message channel binder.

This allows the DLQ processing to be agnostic as to who created the
error message.
artembilan pushed a commit that referenced this issue Jun 11, 2019
Resolves #2958

The previous commit added the raw source message to a common header
`IntegrationMessageHeaderAccessor.SOURCE_DATA` so that the spring-cloud-stream
can construct an error message containing the data when using functions.

However, we also need to add it to the common header when the `ErrorMessage`
is created by Spring Integration for the normal message channel binder.

This allows the DLQ processing to be agnostic as to who created the
error message.

(cherry picked from commit 78a0ec7)
garyrussell added a commit to garyrussell/spring-integration-kafka that referenced this issue Jun 11, 2019
Resolves spring-projects/spring-integration#2958

Enables applications to be agnostic regarding the source of
a message. e.g Kafka Vs. AMQP.
artembilan pushed a commit to spring-attic/spring-integration-kafka that referenced this issue Jun 11, 2019
Resolves spring-projects/spring-integration#2958

Enables applications to be agnostic regarding the source of
a message. e.g Kafka Vs. AMQP.
artembilan pushed a commit to spring-attic/spring-integration-kafka that referenced this issue Jun 11, 2019
Resolves spring-projects/spring-integration#2958

Enables applications to be agnostic regarding the source of
a message. e.g Kafka Vs. AMQP.

# Conflicts:
#	build.gradle
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jun 24, 2020
Resolves spring-projects#2958

Enables applications to be agnostic regarding the source of
a message. e.g Kafka Vs. AMQP.
artembilan pushed a commit that referenced this issue Jun 25, 2020
Resolves #2958

Enables applications to be agnostic regarding the source of
a message. e.g Kafka Vs. AMQP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment