Skip to content

NioFileLocker.unlock #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matiastito opened this issue Jul 1, 2019 · 1 comment · Fixed by #2998
Closed

NioFileLocker.unlock #2980

matiastito opened this issue Jul 1, 2019 · 1 comment · Fixed by #2998
Assignees
@garyrussell
Labels
in: file type: bug
Milestone
5.1.7

Comments

@matiastito
Copy link

matiastito commented Jul 1, 2019 •
edited
Loading

Hi all, It appears to me that there is a bug in NioFileLocker.unlock() method (spring integration v5.1.4.RELEASE).
Method clears up classloader level cache by calling FileChannelCache.closeChannelFor(fileToUnlock);, but it never tries to clean up its local lockCache.
@artembilan
Copy link
Member

Good catch!

Feel free to contribute a fix!

Thanks

@artembilan artembilan added this to the 5.1.7 milestone Jul 1, 2019
@garyrussell garyrussell self-assigned this Jul 22, 2019
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jul 22, 2019
@garyrussell
Clear lock cache in NioFileLocker
9fc9253 
Fixes spring-projects#2980
@garyrussell garyrussell mentioned this issue Jul 22, 2019
Merged
artembilan pushed a commit that referenced this issue Jul 22, 2019
@garyrussell @artembilan
Clear lock cache in NioFileLocker (#2998)
8bb0e19 
Fixes #2980
artembilan pushed a commit that referenced this issue Jul 22, 2019
@garyrussell @artembilan
Clear lock cache in NioFileLocker (#2998)
1e38ff7 
Fixes #2980
# Conflicts:
#	spring-integration-file/src/test/java/org/springframework/integration/file/locking/NioFileLockerTests.java
artembilan pushed a commit that referenced this issue Jul 22, 2019
@garyrussell @artembilan
Clear lock cache in NioFileLocker (#2998)
f5517a0 
Fixes #2980
# Conflicts:
#	spring-integration-file/src/test/java/org/springframework/integration/file/locking/NioFileLockerTests.java
artembilan pushed a commit that referenced this issue Jul 22, 2019
@garyrussell @artembilan
Clear lock cache in NioFileLocker (#2998)
f2bd8c4 
Fixes #2980
# Conflicts:
#	spring-integration-file/src/test/java/org/springframework/integration/file/locking/NioFileLockerTests.java

# Conflicts:
#	spring-integration-file/src/main/java/org/springframework/integration/file/locking/NioFileLocker.java
#	spring-integration-file/src/test/java/org/springframework/integration/file/locking/NioFileLockerTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: file type: bug
Projects
None yet
Milestone
5.1.7
Development

Successfully merging a pull request may close this issue.

Clear lock cache in NioFileLocker garyrussell/spring-integration
3 participants
@garyrussell @artembilan @matiastito