Skip to content

Add (S)FTP source server information to messages #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Aug 23, 2019 · 3 comments · Fixed by #3044
Closed

Add (S)FTP source server information to messages #3043

garyrussell opened this issue Aug 23, 2019 · 3 comments · Fixed by #3044
Assignees
@artembilan
Labels
in: sftp type: enhancement
Milestone
5.2.RC1

Comments

@garyrussell
Copy link
Contributor

See https://stackoverflow.com/questions/57606912/spring-integration-java-dsl-sftp-how-to-get-remote-sftp-server-information-in-ha/57609407#57609407
@garyrussell garyrussell added this to the 5.2.RC1 milestone Aug 23, 2019
@artembilan artembilan self-assigned this Aug 23, 2019
artembilan added a commit to artembilan/spring-integration that referenced this issue Aug 23, 2019
@artembilan
spring-projectsGH-3043: Add FileHeaders.REMOTE_HOST header
ef4b560 
Fixes spring-projects#3043

* Populate a `FileHeaders.REMOTE_HOST` from the
`AbstractRemoteFileStreamingMessageSource` and "get"-based commands
in the `AbstractRemoteFileOutboundGateway`
* Extract the value from the a `Session.getHost()` contract
* The `AbstractInboundFileSynchronizingMessageSource` cannot be
addressed with this because the real message is already based on the
locally stored file
* Adjust some affected tests according our code style requirements
@artembilan artembilan mentioned this issue Aug 23, 2019
Merged
artembilan added a commit to artembilan/spring-integration that referenced this issue Aug 27, 2019
@artembilan
spring-projectsGH-3043: Add FileHeaders.REMOTE_HOST header
4906e6c 
Fixes spring-projects#3043

* Populate a `FileHeaders.REMOTE_HOST` from the
`AbstractRemoteFileStreamingMessageSource` and "get"-based commands
in the `AbstractRemoteFileOutboundGateway`
* Extract the value from the a `Session.getHost()` contract
* The `AbstractInboundFileSynchronizingMessageSource` cannot be
addressed with this because the real message is already based on the
locally stored file
* Adjust some affected tests according our code style requirements
garyrussell pushed a commit that referenced this issue Aug 28, 2019
@artembilan @garyrussell
GH-3043: Add FileHeaders.REMOTE_HOST header (#3044)
a756e63 
* GH-3043: Add FileHeaders.REMOTE_HOST header

Fixes #3043

* Populate a `FileHeaders.REMOTE_HOST` from the
`AbstractRemoteFileStreamingMessageSource` and "get"-based commands
in the `AbstractRemoteFileOutboundGateway`
* Extract the value from the a `Session.getHost()` contract
* The `AbstractInboundFileSynchronizingMessageSource` cannot be
addressed with this because the real message is already based on the
locally stored file
* Adjust some affected tests according our code style requirements

* * Add remote file info support into `AbstractInboundFileSynchronizingMessageSource`
* Introduce a `MetadataStore` functionality into the `AbstractInboundFileSynchronizer`
to gather a remote file info an save it in the URI style against local file
* Retrieve such an info in the `AbstractInboundFileSynchronizingMessageSource`
during local file polling
* Introduce `protocol()` contract for the `AbstractInboundFileSynchronizer`
to build a proper URI in the metadata for external readers to distinguish
remote files properly
* Document the feature

* * Fix some typos in Docs

* * Rename property and header constant to the `HOST_PORT` pair
* Fix typos in Docs
* Add  `remote-file-metadata-store` and `metadata-store-prefix` into XSD
of (S)FTP Inbound Channel Adapters
* Add `remoteFileMetadataStore` and `metadataStorePrefix` options
into `RemoteFileInboundChannelAdapterSpec` for Java DSL
@artembilan
Copy link
Member

Migration Guide note: https://github.com/spring-projects/spring-integration/wiki/Spring-Integration-5.1-to-5.2-Migration-Guide#sftp-session-gethostport-contract

@garyrussell
Copy link
Contributor Author

I guess we will need an update to s-i-aws.

@artembilan
Copy link
Member

an update to s-i-aws.

Will do today and comeback with some polishing if that. I somehow don't believe that I will be able to extract AWS port 😄

artembilan added a commit to spring-projects/spring-integration-aws that referenced this issue Aug 29, 2019
@artembilan
Add S3 remote file info into headers
197da9f 
Related to spring-projects/spring-integration#3043
Griffin1989106 added a commit to Griffin1989106/SpringWithAWS that referenced this issue Jul 22, 2024
@Griffin1989106
Add S3 remote file info into headers
a028ea3 
Related to spring-projects/spring-integration#3043
guygriffin1989106 added a commit to guygriffin1989106/SpringWithAWS that referenced this issue Jul 26, 2024
@guygriffin1989106
Add S3 remote file info into headers
1c032e0 
Related to spring-projects/spring-integration#3043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: sftp type: enhancement
Projects
None yet
Milestone
5.2.RC1
Development

Successfully merging a pull request may close this issue.

GH-3043: Add FileHeaders.REMOTE_HOST header artembilan/spring-integration
2 participants
@garyrussell @artembilan