FileChannelCache.tryLockFor creates empty files

[EmmanuelRoux]

Hi all

FileChannelCache.tryLockFor(File) actually creates an empty file when trying to get a lock on a non-existent file.

It seems to be caused by line 56 FileChannel newChannel = new RandomAccessFile(fileToLock, "rw").getChannel(); which opens the file using "rw" mode (create the file if it does not exist)

Tested on v5.1.5.RELEASE, seems to still be the same on v5.2.0.RELEASE.

It may be better to either :

• throw an exception to indicate the file does not exist
• return a specific value to indicate the file does not exist
• or just document that behavior

To reproduce, just call :

FileChannelCache.tryLockFor(new File("/a/file/that/does/not/exists.txt"));

Thanks!