Skip to content

Issue with AbstractCorrelatingMessageHandler in handling sequences if used in nested ScatterGather sequence #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirimamilla opened this issue Jan 27, 2020 · 5 comments

Comments

@sirimamilla
Copy link
Contributor

Affects Version(s): 5.2.x, 5.1.x

If the output processor in ScatterGather returns a message, Scatter Gather is hanging indefinitely.
This issue is present with all versions of Spring Integration.

This can be tested with SI version 5.1.3

Please find the test case here in the example git project.
https://github.com/sirimamilla/ScatterGatherTest

@sirimamilla
Copy link
Contributor Author

I have the fix for the issue, once the issue is accepted, I will open pull request for the same. Currently I am not able to raise the pull request as it is dependent of fix for #3152

This fix needs to be done along with or after Pull Request #3153. To test the fix, issue 3152 needs to be resolved.

@artembilan
Copy link
Member

@sirimamilla ,

tell me, please, how this issue is different from that one you are mentioning in the opened PR.

Thanks

@sirimamilla
Copy link
Contributor Author

Hi @artembilan,

The issue mentioned in PR is a new bug that is introduced in 5.1.7 and above and is related to Original_ Header handling.

This issue is related to Sequence Handling that has one unhandled scenario. If we agree that this fix can be merged along with PR #3153. I will push this fix to PR #3153

@artembilan
Copy link
Member

No, let's hold of from complicating that PR.
I'm about for final review and merging that one.

We can come back to this afterwards.

So, stay tuned!

@sirimamilla
Copy link
Contributor Author

I have not pushed the changes to Test application, so you were not able to see the difference. you can review test application now.

sirimamilla added a commit to sirimamilla/spring-integration that referenced this issue Jan 27, 2020
sirimamilla added a commit to sirimamilla/spring-integration that referenced this issue Jan 31, 2020
sirimamilla added a commit to sirimamilla/spring-integration that referenced this issue Jan 31, 2020
@artembilan artembilan added this to the 5.3 M2 milestone Jan 31, 2020
sirimamilla added a commit to sirimamilla/spring-integration that referenced this issue Jan 31, 2020
sirimamilla added a commit to sirimamilla/spring-integration that referenced this issue Jan 31, 2020
sirimamilla added a commit to sirimamilla/spring-integration that referenced this issue Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants