Skip to content

Rsocket InboundGateway message handling should be consistent with regular @Controller/@MessageMapping #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hantsy opened this issue Mar 3, 2020 · 0 comments · Fixed by #3208
Closed

Rsocket InboundGateway message handling should be consistent with regular @Controller/@MessageMapping #3207

hantsy opened this issue Mar 3, 2020 · 0 comments · Fixed by #3208
Assignees
@artembilan
Labels
in: rsocket type: enhancement
Milestone
5.3.M3

Comments

@hantsy
Copy link

hantsy commented Mar 3, 2020 •
edited
Loading

The original question is posted on StackOverflow, check here.

My code sample is here.

Currently, I have to add a new line delimiter to every item in the Flux in the client and let server side know it should be a Flux.

Flux.just("a\n", "b\n", "c\n", "d\n")

Currently, I have not tried other interaction modes Like regular @Controller/@RequestMapping, RSocketInboundGateway should accept the following payloads.

  • (empty)
  • T
  • Mono<T>
  • Flux<T>

The following explanation is quoted from the answer from @artembilan:

Currently the server side of Spring Integration doesn't treat an incoming Flux as a stream of independent payloads. So, we try to connect all of them into a single value. The new line delimiter is an indicator that we expect independent values. Spring Messaging on its side does exactly opposite: it checks for multi-value expected type and decode every element in the incoming Flux in its map() instead of an attempt for the whole Publisher decoding.

It's going to be kinda breaking change, but possibly need to consider to fix RSocketInboundGateway logic to be consistent with regular @MessageMapping for RSocket support.
@hantsy hantsy changed the title Rsocket InboundGateway message handling should be consistent with regauler @MessageMapping Rsocket InboundGateway message handling should be consistent with regular @Controller/@MessageMapping Mar 3, 2020
@artembilan artembilan added this to the 5.3.M3 milestone Mar 3, 2020
@artembilan artembilan self-assigned this Mar 4, 2020
artembilan added a commit to artembilan/spring-integration that referenced this issue Mar 4, 2020
@artembilan
spring-projectsGH-3207: RSocket inbound: decode each flux item
e32b26a 
Fixes spring-projects#3207

Previously an incoming RSocket Publisher has been decoded as a single unit
leading to extra work on the client side, e.g. a delimiter has to be provided
to treat each payload item as independent

* To have a consistency with Spring Messaging and its `PayloadMethodArgumentResolver`
change an `RSocketInboundGateway` to process inbound payloads as `Flux` and decode
each item independently.
* Change `RSocketDslTests` to remove delimiters and make it consistent with the regular
`RSocketRequester` client
@artembilan artembilan mentioned this issue Mar 4, 2020
Merged
artembilan added a commit to artembilan/spring-integration that referenced this issue Mar 5, 2020
@artembilan
spring-projectsGH-3207: RSocket inbound: decode each flux item
ca79b4f 
Fixes spring-projects#3207

Previously an incoming RSocket Publisher has been decoded as a single unit
leading to extra work on the client side, e.g. a delimiter has to be provided
to treat each payload item as independent

* To have a consistency with Spring Messaging and its `PayloadMethodArgumentResolver`
change an `RSocketInboundGateway` to process inbound payloads as `Flux` and decode
each item independently.
* Change `RSocketDslTests` to remove delimiters and make it consistent with the regular
`RSocketRequester` client
garyrussell pushed a commit that referenced this issue Mar 10, 2020
@artembilan
GH-3207: RSocket inbound: decode each flux item (#3208)
c45cc66 
* GH-3207: RSocket inbound: decode each flux item

Fixes #3207

Previously an incoming RSocket Publisher has been decoded as a single unit
leading to extra work on the client side, e.g. a delimiter has to be provided
to treat each payload item as independent

* To have a consistency with Spring Messaging and its `PayloadMethodArgumentResolver`
change an `RSocketInboundGateway` to process inbound payloads as `Flux` and decode
each item independently.
* Change `RSocketDslTests` to remove delimiters and make it consistent with the regular
`RSocketRequester` client

* * Add `decodeFluxAsUnit` option into `RSocketInboundGateway`
* Document the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
in: rsocket type: enhancement
Projects
None yet
Milestone
5.3.M3
Development

Successfully merging a pull request may close this issue.

GH-3207: RSocket inbound: decode each flux item artembilan/spring-integration
2 participants
@hantsy @artembilan