Skip to content

GH-10083: Migrate ZeroMQ module to Jspecify #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthologia
Copy link
Contributor

@anthologia anthologia commented Jun 9, 2025

Related to: #10083

Changes:

  • Replaced org.springframework.lang.Nullable with org.jspecify.annotations.Nullable

Should I create separate PRs for each module?

Fixes: spring-projects#10083

- Replaced `org.springframework.lang.Nullable` with `org.jspecify.annotations.Nullable`

Signed-off-by: Jooyoung Pyoung <[email protected]>
@artembilan
Copy link
Member

Fixes: #10083

Is not correct in the PR since it does not fully fix the whole issue.
Please, don't use it for this kind of PRs again.
Better like Related to:

Should I create separate PRs for each module?

Yes, please.
That will be easier for us to review.

Thanks

@artembilan artembilan added this to the 7.0.0-M1 milestone Jun 9, 2025
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this was automated, but can we also look into migrating those package-info.java files in this module to the org.jspecify.annotations.NullMarked instead of those deprecated over there?
Then it would be great to run gradlew :spring-integration-zeromq:check and see if your change passes NullAway.

Thanks

@artembilan
Copy link
Member

I know the org.jspecify.annotations.NullMarked is a phase 2 in our issue roadmap, but that is OK to do that for such a small module in one go, so we would know where we are for the rest of the project.

Thanks

@artembilan
Copy link
Member

We have just merged one for Camel module: b07d04f.

Feel free to follow its experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants