Fix code smell in websocket and webflux modules #2669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis reports a checkstyle problem. |
garyrussell
suggested changes
Dec 19, 2018
| @@ -39,6 +40,7 @@ | |||
|
|
|||
| @Override | |||
| public boolean supports(HandlerResult result) { | |||
| Assert.notNull(result, "'result' must not be null"); | |||
There was a problem hiding this comment.
I don't think we need this assert; Spring will never call this with a null result.
| @@ -47,6 +49,7 @@ public boolean supports(HandlerResult result) { | |||
| @Override | |||
| @SuppressWarnings("unchecked") | |||
| public Mono<Void> handleResult(ServerWebExchange exchange, HandlerResult result) { | |||
| Assert.notNull(result, "'result' must not be null"); | |||
There was a problem hiding this comment.
I don't think this is the reported issue; the problem is result.getReturnValue() can return null, which is not allowed by the handleResult contract.
garyrussell
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.