Fix mail lock race condition & Sonar smells #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://build.spring.io/browse/INT-MASTERSPRING40-599/ * The `folderReadLock` might not be re-locked when `openFolder()` throws an exception * Fix all the Sonar smells for mail module * Optimize all the dynamic `Assert` messages to `Supplier` * Refactor `MailReceiverFactoryBean` to be based on the `AbstractFactoryBean`
garyrussell
suggested changes
Jan 28, 2019
| Folder folder = getFolder(); | ||
| logger.debug("Canceling IDLE"); | ||
| if (folder != null) { | ||
| folder.isOpen(); // resets idle state | ||
| } | ||
| } |
There was a problem hiding this comment.
I presume this was to avoid log noise. Why change? If your intention is to alert the user of the problem, it would be better to log rather than the task executor printing the stack trace.
| // | ||
| // public static void closeFolder(Folder folder) { | ||
| // closeFolder(folder, false); | ||
| // } |
There was a problem hiding this comment.
Why not just delete this?
* Remove commented code in the `MailTransportUtils`
garyrussell
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://build.spring.io/browse/INT-MASTERSPRING40-599/
folderReadLockmight not be re-locked whenopenFolder()throws an exception
Assertmessages toSupplierMailReceiverFactoryBeanto be based on theAbstractFactoryBean