Add default expressions for ExpEvalReqHAdvice #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://stackoverflow.com/questions/54546728/how-to-handle-ftpoutboundadapter-connection-exception-in-spring-integration-flow When channels are configured for the `ExpressionEvaluatingRequestHandlerAdvice`, but no expressions, the logic is not performed. In other words: we can evaluate expressions, when no channels, but we don't send messages to channels when no expressions. * Provide default expressions to be evaluated to `payload`, when only channels are provided.
garyrussell
suggested changes
Feb 6, 2019
| * @param onSuccessExpression the SpEL expression. | ||
| * @since 5.0 | ||
| */ | ||
| public void setOnSuccessExpression(Expression onSuccessExpression) { | ||
| Assert.notNull(onSuccessExpression, "'onSuccessExpression' must not be null"); |
There was a problem hiding this comment.
Breaking change; someone might have...
advice.setFailureExpression(...);
advice.setSuccessExpression(null);Just for self-documentation purposes.
Maybe 5.2 only? Since the work around is simple?
However, why are these asserts even needed? You retained the null checks in doInvoke().
| @@ -406,6 +406,8 @@ An additional property, called `inputMessage`, contains the original message sen | |||
| A message sent to the `failureChannel` (when the handler throws an exception) is an `ErrorMessage` with a payload of `MessageHandlingExpressionEvaluatingAdviceException`. | |||
| Like all `MessagingException` instances, this payload has `failedMessage` and `cause` properties, as well as an additional property called `evaluationResult`, which contains the result of the expression evaluation. | |||
|
|
|||
| NOTE: Starting with version 5.1.3, if channels are configured, but expressions are not provided, the default expression is used to evaluate to a `payload` of the message. | |||
|
|
|||
There was a problem hiding this comment.
to the payload if the message.
|
Pushed according your advises. I think with the current state it is not a breaking change because previously the channels just haven't had any value. They've been ignored. |
|
I agree, but it's not necessary to assert not null here; and users might have done it, just for completeness; no need to break such apps. |
garyrussell
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/54546728/how-to-handle-ftpoutboundadapter-connection-exception-in-spring-integration-flow
When channels are configured for the
ExpressionEvaluatingRequestHandlerAdvice,but no expressions, the logic is not performed.
In other words: we can evaluate expressions, when no channels,
but we don't send messages to channels when no expressions.
payload, when onlychannels are provided.