INT-3459: Log exceptions in case of failOver #2790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Mar 7, 2019
| catch (Exception ex) { | ||
| RuntimeException runtimeException = | ||
| IntegrationUtils.wrapInDeliveryExceptionIfNecessary(message, | ||
| () -> "Dispatcher failed to deliver Message", ex); |
There was a problem hiding this comment.
Why this line wrap? It was previously 112.
There was a problem hiding this comment.
Well, my own preferences: I find it is much readable when variable initialization is multi-line. So, I start initialization block fully from a new line.
| boolean isLast = !handlerIterator.hasNext(); | ||
| if (!isLast && this.failover && this.logger.isInfoEnabled()) { | ||
| this.logger.info("An exception thrown from the '" + handler + "' for the '" + message + "'. " + | ||
| "Will be in a failover for the next subscriber.", ex); |
There was a problem hiding this comment.
Sorry for my language, but the two the should be removed.
this.logger.info("An exception was thrown by '" + handler + "' for while handling '" + message + "'. " +
"Failing over to the next subscriber.", ex);There was a problem hiding this comment.
Perhaps only include full stack trace at DEBUG and ex.getMessage() at INFO?
| @@ -137,18 +137,24 @@ private boolean doDispatch(Message<?> message) { | |||
| if (!handlerIterator.hasNext()) { | |||
| throw new MessageDispatchingException(message, "Dispatcher has no subscribers"); | |||
| } | |||
| List<RuntimeException> exceptions = new ArrayList<RuntimeException>(); | |||
| List<RuntimeException> exceptions = new ArrayList<>(); | |||
There was a problem hiding this comment.
We should create this array lazily because it's only used in error situations. 99.9999% not used.
JIRA: https://jira.spring.io/browse/INT-3459 When `UnicastingDispatcher` is configured with `failOver` (true by default), it loses exceptions it caught with previous handler when the next one processes message properly * Add INFO logging for exceptions which are caught before going to fail over to the next handler
garyrussell
suggested changes
Mar 7, 2019
| } | ||
| else if (this.logger.isDebugEnabled()) { | ||
| this.logger.debug("An exception was thrown by '" + handler + "' while handling '" + message + | ||
| "'. Failing over to the next subscriber.", ex); |
There was a problem hiding this comment.
Debug has to be detected first otherwise we'll always take the INFO branch.
* Add a note about this logging into the `channel.adoc`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-3459
When
UnicastingDispatcheris configured withfailOver(true by default),it loses exceptions it caught with previous handler when the next one
processes message properly
over to the next handler