Fix RedisAvailableRule #2796
Merged
Fix RedisAvailableRule #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
fix-redis-available-rule
branch
from
93e6828 to
4f968e4
Compare
|
Excellent; thanks for the contribution. Do you want to add your name to the |
marcphilipp
force-pushed
the
fix-redis-available-rule
branch
from
4f968e4 to
097d6b0
Compare
|
Done. 🙂 |
marcphilipp
force-pushed
the
fix-redis-available-rule
branch
from
097d6b0 to
4dc8677
Compare
Prior to this commit, `RedisAvailableRule.apply()` threw an `AssumptionViolatedException` when Redis was unavailable. That caused the execution of the current test class and all pending test methods to be stopped immediately. Instead, it now returns a `Statement` that throws the exception in case Redis is unavailable which will only skip the current test. Resolves spring-projects#2782.
marcphilipp
force-pushed
the
fix-redis-available-rule
branch
from
4dc8677 to
f56a0ca
Compare
|
I've now also fixed a typo in the commit message and removed a superfluous blank line. |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
RedisAvailableRule.apply()threw anAssumptionViolatedExceptionwhen Redis was unavailable. That causedthe execution of the current test class and all pending test methods to
be stopped immediately. Instead, it now returns a
Statementthatthrows the exception in case Redis is unavailable which will only skip
the current test.
Resolves #2782.