INT-2277: Register ChResolver & ErrHandler beans #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm - no travis for some reason - I checked and all is enabled. I wonder if they suppress a build because there are conflicts? Perhaps rebase and see? |
JIRA: https://jira.spring.io/browse/INT-2277 To avoid extra objects at runtime and reuse a central configuration, register `BeanFactoryChannelResolver` and `MessagePublishingErrorHandler` bean via `DefaultConfiguringBeanFactoryPostProcessor` * Use those beans whenever it is necessary via `IntegrationContextUtils` factory methods against provided `BeanFactory` * To avoid changes in the non-managed test, those new factories fall back to a new instance if there is no an appropriate bean in the `beanFactory`
|
OK. Now it's back after rebasing. |
garyrussell
reviewed
Mar 14, 2019
| * @param metadataSource the {@link PublisherMetadataSource} to use. | ||
| * @deprecated since 5.2 in favor constructor argument. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
See INT-954, not sure if it's still relevant.
There was a problem hiding this comment.
Well, I'm not sure what is that tooling, but I guess we have already much more components with similar ctor-based initialization and no one has complained so far.
Therefore I believe we are safe to remove it now.
Well, at least deprecate since it is a mandatory ctor option anyway, but someone may still would like to call a setter. Although that is already not so good to mutate this component at runtime.
| /** | ||
| * Obtain a {@link DestinationResolver} registered with the | ||
| * {@value #CHANNEL_RESOLVER_BEAN_NAME} bean name. | ||
| * @param beanFactory BeanFactory for lookup, must not be null. |
| * {@value #MESSAGE_PUBLISHING_ERROR_HANDLER_BEAN_NAME} bean name. | ||
| * By default resolves to the {@link org.springframework.integration.channel.MessagePublishingErrorHandler} | ||
| * with the {@value #CHANNEL_RESOLVER_BEAN_NAME} {@link DestinationResolver} bean. | ||
| * @param beanFactory BeanFactory for lookup, must not be null. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-2277
To avoid extra objects at runtime and reuse a central configuration,
register
BeanFactoryChannelResolverandMessagePublishingErrorHandlerbean via
DefaultConfiguringBeanFactoryPostProcessorIntegrationContextUtilsfactory methods against provided
BeanFactoryback to a new instance if there is no an appropriate bean in the
beanFactory