Support generics in the JsonToObjectTransformer#2819
Merged
garyrussell merged 2 commits intospring-projects:masterfrom Mar 18, 2019
Merged
Support generics in the JsonToObjectTransformer#2819garyrussell merged 2 commits intospring-projects:masterfrom
JsonToObjectTransformer#2819garyrussell merged 2 commits intospring-projects:masterfrom
Conversation
garyrussell
suggested changes
Mar 18, 2019
Contributor
garyrussell
left a comment
garyrussell
left a comment
There was a problem hiding this comment.
Just one minor issue.
...gration-core/src/main/java/org/springframework/integration/json/JsonToObjectTransformer.java
Outdated
Show resolved
Hide resolved
* Deprecate `JsonObjectMapperAdapter` if favor of `default` methods in the `JsonObjectMapper` * Introduce `JsonObjectMapper.fromJson(Object, ResolvableType)` to support generics during deserialization * Add `JsonHeaders.RESOLVABLE_TYPE` header handling for the `ResolvableType` management * Add `ResolvableType` argument into the `JsonToObjectTransformer` * Change the `JsonToObjectTransformer` logic to consult request message headers first * Add `ResolvableType`-based factory method into the `Transformers` * Document the change
in the `JsonToObjectTransformer`
artembilan
force-pushed
the
Generics_for_JSON2Object
branch
from
f282dbd to
055f56c
Compare
garyrussell
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonObjectMapperAdapterif favor ofdefaultmethods inthe
JsonObjectMapperJsonObjectMapper.fromJson(Object, ResolvableType)tosupport generics during deserialization
JsonHeaders.RESOLVABLE_TYPEheader handling for theResolvableTypemanagementResolvableTypeargument into theJsonToObjectTransformerJsonToObjectTransformerlogic to consult request messageheaders first
ResolvableType-based factory method into theTransformers